Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIRFLOW-6399] Validate _access control in deserialized DAGs #7896

Merged
merged 1 commit into from
Mar 26, 2020
Merged

[AIRFLOW-6399] Validate _access control in deserialized DAGs #7896

merged 1 commit into from
Mar 26, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 26, 2020

2d0db94 takes care of Serialized version

Make sure to mark the boxes below before creating PR: [x]

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested a review from potiuk March 26, 2020 21:43
@codecov-io
Copy link

Codecov Report

Merging #7896 into master will decrease coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7896      +/-   ##
==========================================
- Coverage   87.09%   86.36%   -0.74%     
==========================================
  Files         928      928              
  Lines       45025    45025              
==========================================
- Hits        39216    38884     -332     
- Misses       5809     6141     +332
Impacted Files Coverage Δ
...flow/providers/apache/cassandra/hooks/cassandra.py 21.25% <0.00%> (-72.50%) ⬇️
...w/providers/apache/hive/operators/mysql_to_hive.py 35.84% <0.00%> (-64.16%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0.00%> (-55.56%) ⬇️
airflow/providers/postgres/operators/postgres.py 47.82% <0.00%> (-52.18%) ⬇️
airflow/providers/redis/operators/redis_publish.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/kubernetes/volume.py 52.94% <0.00%> (-47.06%) ⬇️
airflow/providers/mongo/sensors/mongo.py 53.33% <0.00%> (-46.67%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0.00%> (-45.08%) ⬇️
airflow/providers/mysql/operators/mysql.py 55.00% <0.00%> (-45.00%) ⬇️
airflow/providers/redis/sensors/redis_key.py 61.53% <0.00%> (-38.47%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c65e3...8b3eecf. Read the comment docs.

@kaxil kaxil merged commit 2a98a61 into apache:master Mar 26, 2020
@kaxil kaxil deleted the s10n-add-dag-ops branch March 26, 2020 22:34
kaxil added a commit that referenced this pull request Mar 27, 2020
@kaxil
[AIRFLOW-6399] Add _access control to validate deserialized DAGs (#7896)
b57200b 
(cherry picked from commit 2a98a61)
kaxil added a commit that referenced this pull request Mar 27, 2020
@kaxil
[AIRFLOW-6399] Add _access control to validate deserialized DAGs (#7896)
1fdec7a 
(cherry picked from commit 2a98a61)
kaxil added a commit to astronomer/airflow that referenced this pull request Mar 30, 2020
@kaxil
[AIRFLOW-6399] Add _access control to validate deserialized DAGs (apa…
b886436 
…che#7896)

(cherry picked from commit 2a98a61)
kaxil added a commit that referenced this pull request Mar 30, 2020
@kaxil
[AIRFLOW-6399] Add _access control to validate deserialized DAGs (#7896)
a17521f 
(cherry picked from commit 2a98a61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
area:serialization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaxil @codecov-io @potiuk